Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent destroyed view references from causing crashes #25609

Merged
merged 1 commit into from Sep 25, 2020
Merged

fix: prevent destroyed view references from causing crashes #25609

merged 1 commit into from Sep 25, 2020

Conversation

mlaurencin
Copy link
Contributor

@mlaurencin mlaurencin commented Sep 23, 2020 •
edited

Description of Change

Backport of #25411

@codebytere

Checklist

Release Notes

Notes: Fixed crashes caused by attempting to modify destroyed views

@trop trop bot mentioned this pull request Sep 23, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 23, 2020
@codebytere codebytere changed the title fix: handle backporting from PR #25411 fix: prevent destroyed view references from causing crashes Sep 23, 2020
@codebytere codebytere requested a review from a team September 23, 2020 20:51
@codebytere codebytere mentioned this pull request Sep 23, 2020
Closed
jkleinsc
jkleinsc previously requested changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some legitimate test failures happening

shell/browser/native_window_mac.mm Outdated Show resolved Hide resolved
@codebytere codebytere dismissed jkleinsc’s stale review September 25, 2020 16:41

Test failures have all been resolved :)

@codebytere codebytere merged commit 858d74b into electron:9-x-y Sep 25, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 25, 2020

Release Notes Persisted

Fixed crashes caused by attempting to modify destroyed views

@codebytere codebytere mentioned this pull request Sep 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mlaurencin @jkleinsc @codebytere